Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2740883002: cryptohome: Add the conversion for a new error code. (Closed)

Created:
3 years, 9 months ago by kinaba
Modified:
3 years, 9 months ago
Reviewers:
hashimoto, Darren Krahn
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cryptohome: Add the conversion for a new error code. This CL depends on https://chromium-review.googlesource.com/c/452097/ BUG=699436 TEST=none (no behavior change at this point.) Review-Url: https://codereview.chromium.org/2740883002 Cr-Commit-Position: refs/heads/master@{#456357} Committed: https://chromium.googlesource.com/chromium/src/+/8a9749142275a2eae0ab63da86ec41905d199812

Patch Set 1 #

Patch Set 2 : cryptohome: Add the conversion for a new error code. #

Patch Set 3 : Name change reflecting the main CL's review comment. #

Patch Set 4 : Roll DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kinaba
PTAL (This CL itself is nearly mechanical derivative of https://chromium-review.googlesource.com/c/452097/, so I'd like you to ...
3 years, 9 months ago (2017-03-09 08:07:42 UTC) #2
Darren Krahn
+hashimoto lgtm modulo concerns about naming for ABORTED_MIGRATION
3 years, 9 months ago (2017-03-09 18:52:14 UTC) #4
kinaba
Thanks. I'll reflect the final version once it is decided in the system_api CL.
3 years, 9 months ago (2017-03-10 05:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740883002/60001
3 years, 9 months ago (2017-03-13 12:46:20 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 12:50:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8a9749142275a2eae0ab63da86ec...

Powered by Google App Engine
This is Rietveld 408576698