components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java - Issue 2740873004: Allow AccountManagerHelper.updateCredentials callback param to be null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java

Issue 2740873004: Allow AccountManagerHelper.updateCredentials callback param to be null (Closed)

Patch Set: Addressed comments 2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java ('k') | components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java

diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java

index 0d71fa45f50764e662af15ea6c06d52c2f29f49c..93745b6e323656e785ab60f6ef2d93f02bc1398d 100644

--- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java

+++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java

@@ -9,6 +9,7 @@ import android.accounts.AuthenticatorDescription;

import android.app.Activity;

import android.content.Context;

import android.os.AsyncTask;

+import android.support.annotation.Nullable;

import org.chromium.base.Callback;

import org.chromium.base.Log;

@@ -354,7 +355,8 @@ public class AccountManagerHelper {

* Asks the user to enter a new password for an account, updating the saved credentials for the

* account.

- public void updateCredentials(Account account, Activity activity, Callback<Boolean> callback) {

+ public void updateCredentials(

+ Account account, Activity activity, @Nullable Callback<Boolean> callback) {

mAccountManager.updateCredentials(account, activity, callback);

}