components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java - Issue 2740873004: Allow AccountManagerHelper.updateCredentials callback param to be null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java

Issue 2740873004: Allow AccountManagerHelper.updateCredentials callback param to be null (Closed)

Patch Set: Addressed comments 2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java ('k') | components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java

diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java

index 436e0d162cc5042ebac12ddd8f3e802e53f951a2..249c4e951e5935b964e93e24edf06e6a0928e2ed 100644

--- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java

+++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerDelegate.java

@@ -8,6 +8,7 @@ import android.accounts.Account;

import android.accounts.AuthenticatorDescription;

import android.app.Activity;

import android.support.annotation.AnyThread;

+import android.support.annotation.Nullable;

import android.support.annotation.WorkerThread;

import org.chromium.base.Callback;

@@ -80,5 +81,6 @@ public interface AccountManagerDelegate {

* @param callback The callback to indicate whether update is succeed or not.

@AnyThread

- void updateCredentials(Account account, Activity activity, Callback<Boolean> callback);

+ void updateCredentials(

+ Account account, Activity activity, @Nullable Callback<Boolean> callback);

}