Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2740873003: Make SpellChecker::removeMarkers() to take EphemeralRange instead of VisibleSelection (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SpellChecker::removeMarkers() to take EphemeralRange instead of VisibleSelection This patch makes |SpellChecker::removeMarkers()| to take |EphemeralRange| instead of |VisibleSelection| as preparation of reduce usage of |VisibleSelection| for improving code health. BUG=657237 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2740873003 Cr-Commit-Position: refs/heads/master@{#455705} Committed: https://chromium.googlesource.com/chromium/src/+/72f3c9b47d08185135faeab172c1130f34f1ca66

Patch Set 1 : 2017-03-09T14:47:18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-09 06:56:03 UTC) #7
yoichio
lgtm
3 years, 9 months ago (2017-03-09 08:54:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740873003/1
3 years, 9 months ago (2017-03-09 09:03:57 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 09:10:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72f3c9b47d08185135faeab172c1...

Powered by Google App Engine
This is Rietveld 408576698