Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2740863004: support gitiles smart quoting (Closed)

Created:
3 years, 9 months ago by vapier
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

support gitiles smart quoting Convert dumb single/double quotes to smart quotes just like gitiles. R=dpranke@chromium.org BUG= Review-Url: https://codereview.chromium.org/2740863004 Cr-Commit-Position: refs/heads/master@{#455693} Committed: https://chromium.googlesource.com/chromium/src/+/98832b81e0bb8f06df0c49ce9b0a262d4b47dea3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A tools/md_browser/gitiles_smart_quotes.py View 1 chunk +39 lines, -0 lines 0 comments Download
M tools/md_browser/md_browser.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
vapier
3 years, 9 months ago (2017-03-09 03:58:05 UTC) #1
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-09 05:08:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740863004/1
3 years, 9 months ago (2017-03-09 07:16:29 UTC) #4
commit-bot: I haz the power
Failed to apply patch for tools/md_browser/md_browser.py: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-09 07:33:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740863004/20001
3 years, 9 months ago (2017-03-09 07:39:56 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 07:54:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98832b81e0bb8f06df0c49ce9b0a...

Powered by Google App Engine
This is Rietveld 408576698