Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2740863002: Revert of Buffer 2 seconds of data in the ffmpeg demuxer. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Buffer 2 seconds of data in the ffmpeg demuxer. (patchset #3 id:40001 of https://codereview.chromium.org/2737653002/ ) Reason for revert: Broke layout test compositing/video/video-poster.html on Mac, Linux ASAN: https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.9/43534 https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.10/31122 https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/1414 Original issue's description: > Buffer 2 seconds of data in the ffmpeg demuxer. > > This has been shown to reduce jank in badly muxed mp4 files. > > BUG=540898 > > Review-Url: https://codereview.chromium.org/2737653002 > Cr-Commit-Position: refs/heads/master@{#455551} > Committed: https://chromium.googlesource.com/chromium/src/+/e23907eaba82f5595b74fb0094968481d6e00514 TBR=dalecurtis@chromium.org,dalecurtis@google.com,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540898 Review-Url: https://codereview.chromium.org/2740863002 Cr-Commit-Position: refs/heads/master@{#455648} Committed: https://chromium.googlesource.com/chromium/src/+/4ea3f616e30bd2c052b44e4455988b4362cbb0ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M media/filters/ffmpeg_demuxer.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Sam McNally
Created Revert of Buffer 2 seconds of data in the ffmpeg demuxer.
3 years, 9 months ago (2017-03-09 02:43:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740863002/1
3 years, 9 months ago (2017-03-09 02:44:27 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 02:45:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ea3f616e30bd2c052b44e445598...

Powered by Google App Engine
This is Rietveld 408576698