Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2740853002: Use PreloadCheckGroup in ExtensionInstallChecker. Make RequirementsChecker a PreloadCheck. (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, srahim+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PreloadCheckGroup in ExtensionInstallChecker. Make RequirementsChecker a PreloadCheck. Not ready for review, here as an FYI. BUG= COMMIT=false NOREVIEW

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -579 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 3 chunks +1 line, -6 lines 0 comments Download
D chrome/browser/extensions/chrome_requirements_checker.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/extensions/chrome_requirements_checker.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 9 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_checker.h View 7 chunks +35 lines, -42 lines 0 comments Download
M chrome/browser/extensions/extension_install_checker.cc View 2 chunks +68 lines, -114 lines 0 comments Download
M chrome/browser/extensions/extension_install_checker_unittest.cc View 14 chunks +128 lines, -158 lines 0 comments Download
M chrome/browser/extensions/requirements_checker_browsertest.cc View 8 chunks +27 lines, -25 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 9 chunks +28 lines, -26 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/management/management_api.h View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/management/management_api.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M extensions/browser/api/management/management_api_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/preload_check.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/preload_check_group.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/requirements_checker.h View 2 chunks +31 lines, -14 lines 0 comments Download
A extensions/browser/requirements_checker.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M extensions/strings/extensions_strings.grd View 2 chunks +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2745433002 Patch 1

Messages

Total messages: 1 (1 generated)
michaelpg
3 years, 9 months ago (2017-03-10 09:12:08 UTC) #1 
Description was changed from

==========
Use PreloadCheckGroup in ExtensionInstallChecker. Make RequirementsChecker a
PreloadCheck.

BUG=
COMMIT=false
NOREVIEW
==========

to

==========
Use PreloadCheckGroup in ExtensionInstallChecker. Make RequirementsChecker a
PreloadCheck.

Not ready for review, here as an FYI.

BUG=
COMMIT=false
NOREVIEW
==========

Powered by Google App Engine
This is Rietveld 408576698