Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: content/public/browser/navigation_controller.h

Issue 2740843004: Add DCHECK that Reload should never be called with ReloadType::NONE (Closed)
Patch Set: Swapped arguments order in DCHECK_NE Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_controller.h
diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h
index 7ec3ca82f17a394952d5eb8222fb78e7f09d6567..4ece52b3df2a8e9ec780379c87938f386fa81ccf 100644
--- a/content/public/browser/navigation_controller.h
+++ b/content/public/browser/navigation_controller.h
@@ -356,6 +356,7 @@ class NavigationController {
// cases pass in true in production code, but would do false for testing, or
// in cases where no user interface is available for prompting. If a
// transient entry is showing, initiates a new navigation to its URL.
+ // NOTE: |reload_type| should never be NONE.
virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0;
// Removing of entries -------------------------------------------------------
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698