Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: content/public/browser/navigation_controller.h

Issue 2740843004: Add DCHECK that Reload should never be called with ReloadType::NONE (Closed)
Patch Set: Swapped arguments order in DCHECK_NE Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 // Navigates to the specified offset from the "current entry". Does nothing if 349 // Navigates to the specified offset from the "current entry". Does nothing if
350 // the offset is out of bounds. 350 // the offset is out of bounds.
351 virtual void GoToOffset(int offset) = 0; 351 virtual void GoToOffset(int offset) = 0;
352 352
353 // Reloads the current entry under the specified ReloadType. If 353 // Reloads the current entry under the specified ReloadType. If
354 // |check_for_repost| is true and the current entry has POST data the user is 354 // |check_for_repost| is true and the current entry has POST data the user is
355 // prompted to see if they really want to reload the page. In nearly all 355 // prompted to see if they really want to reload the page. In nearly all
356 // cases pass in true in production code, but would do false for testing, or 356 // cases pass in true in production code, but would do false for testing, or
357 // in cases where no user interface is available for prompting. If a 357 // in cases where no user interface is available for prompting. If a
358 // transient entry is showing, initiates a new navigation to its URL. 358 // transient entry is showing, initiates a new navigation to its URL.
359 // NOTE: |reload_type| should never be NONE.
359 virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0; 360 virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0;
360 361
361 // Removing of entries ------------------------------------------------------- 362 // Removing of entries -------------------------------------------------------
362 363
363 // Removes the entry at the specified |index|. If the index is the last 364 // Removes the entry at the specified |index|. If the index is the last
364 // committed index or the pending entry, this does nothing and returns false. 365 // committed index or the pending entry, this does nothing and returns false.
365 // Otherwise this call discards any transient or pending entries. 366 // Otherwise this call discards any transient or pending entries.
366 virtual bool RemoveEntryAtIndex(int index) = 0; 367 virtual bool RemoveEntryAtIndex(int index) = 0;
367 368
368 // Random -------------------------------------------------------------------- 369 // Random --------------------------------------------------------------------
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 455
455 private: 456 private:
456 // This interface should only be implemented inside content. 457 // This interface should only be implemented inside content.
457 friend class NavigationControllerImpl; 458 friend class NavigationControllerImpl;
458 NavigationController() {} 459 NavigationController() {}
459 }; 460 };
460 461
461 } // namespace content 462 } // namespace content
462 463
463 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 464 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698