content/public/browser/navigation_controller.h - Issue 2740843004: Add DCHECK that Reload should never be called with ReloadType::NONE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_controller.h

Issue 2740843004: Add DCHECK that Reload should never be called with ReloadType::NONE (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/navigation_controller.h

diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h

index 7ec3ca82f17a394952d5eb8222fb78e7f09d6567..4ece52b3df2a8e9ec780379c87938f386fa81ccf 100644

--- a/content/public/browser/navigation_controller.h

+++ b/content/public/browser/navigation_controller.h

@@ -356,6 +356,7 @@ class NavigationController {

// cases pass in true in production code, but would do false for testing, or

// in cases where no user interface is available for prompting. If a

// transient entry is showing, initiates a new navigation to its URL.

+ // NOTE: |reload_type| should never be NONE.

virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0;

// Removing of entries -------------------------------------------------------