Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2740843004: Add DCHECK that Reload should never be called with ReloadType::NONE (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/browser/navigation_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 0995603d0b485c4622a977ead8f9d04898f11ac0..67f13eb3a282159818fe1708f50d4a9ca9217658 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -297,6 +297,8 @@ void NavigationControllerImpl::Restore(
void NavigationControllerImpl::Reload(ReloadType reload_type,
bool check_for_repost) {
+ DCHECK_NE(reload_type, ReloadType::NONE);
Charlie Reis 2017/03/10 17:41:05 Minor nit: Swap order of arguments. (DCHECK macro
liaoyuke 2017/03/10 18:00:14 Done.
+
if (transient_entry_index_ != -1) {
// If an interstitial is showing, treat a reload as a navigation to the
// transient entry's URL.
« no previous file with comments | « no previous file | content/public/browser/navigation_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698