Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2740843003: Make kWebContentsAndroidKey unique (Closed)

Created:
3 years, 9 months ago by rwlbuis
Modified:
3 years, 9 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make kWebContentsAndroidKey unique As discussed in CL https://codereview.chromium.org/2681933002. Review-Url: https://codereview.chromium.org/2740843003 Cr-Commit-Position: refs/heads/master@{#456108} Committed: https://chromium.googlesource.com/chromium/src/+/f06a8bf73cce8614d325903a7e96e363fa90ce48

Patch Set 1 #

Patch Set 2 : Standalone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
rwlbuis
PTAL.
3 years, 9 months ago (2017-03-09 21:08:04 UTC) #5
boliu
lgtm
3 years, 9 months ago (2017-03-10 16:56:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740843003/40001
3 years, 9 months ago (2017-03-10 17:27:05 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:12:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f06a8bf73cce8614d325903a7e96...

Powered by Google App Engine
This is Rietveld 408576698