Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2740843002: (Reland) Add microdump_stackwalk target to chromium.android builders. (Closed)

Created:
3 years, 9 months ago by mikecase (-- gone --)
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Add microdump_stackwalk target to chromium.android builders. This will allow the testers to symbolize microdump crash logs. BUG=593106 Review-Url: https://codereview.chromium.org/2740843002 Cr-Commit-Position: refs/heads/master@{#456110} Committed: https://chromium.googlesource.com/chromium/src/+/ba2be2041cc39a7bb71f688a8e7a096c3fcd950a

Patch Set 1 #

Patch Set 2 : Alphabetize the things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M testing/buildbot/chromium.android.json View 1 1 chunk +12 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
mikecase (-- gone --)
Reverted this earlier since generate_breakpad_symbols.py script fails if dump_syms is not built. Also going to ...
3 years, 9 months ago (2017-03-09 02:06:56 UTC) #2
martiniss
lgtm
3 years, 9 months ago (2017-03-09 04:01:29 UTC) #3
bpastene
lgtm
3 years, 9 months ago (2017-03-09 23:29:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740843002/20001
3 years, 9 months ago (2017-03-09 23:58:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/382449)
3 years, 9 months ago (2017-03-10 00:09:59 UTC) #8
mikecase (-- gone --)
Missing LGTM for gn_isolate_map.pyl + dpranke@chromium.org
3 years, 9 months ago (2017-03-10 01:52:14 UTC) #10
Dirk Pranke
lgtm, but we should figure out if these should really be listed as data_deps for ...
3 years, 9 months ago (2017-03-10 01:54:28 UTC) #11
mikecase (-- gone --)
On 2017/03/10 at 01:54:28, dpranke wrote: > lgtm, but we should figure out if these ...
3 years, 9 months ago (2017-03-10 17:40:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740843002/20001
3 years, 9 months ago (2017-03-10 17:41:21 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 18:15:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba2be2041cc39a7bb71f688a8e7a...

Powered by Google App Engine
This is Rietveld 408576698