Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1898)

Unified Diff: chrome/browser/guestview/guestview.h

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed creis's comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/guestview.h
diff --git a/chrome/browser/guestview/guestview.h b/chrome/browser/guestview/guestview.h
index 75db06fed0378b1fc62564a2896fde32b80e32e3..90cf2b958fa61213603f4056bd54913709a2d843 100644
--- a/chrome/browser/guestview/guestview.h
+++ b/chrome/browser/guestview/guestview.h
@@ -43,6 +43,7 @@ class GuestView : public content::BrowserPluginGuestDelegate {
static Type GetViewTypeFromString(const std::string& api_type);
static GuestView* Create(content::WebContents* guest_web_contents,
Charlie Reis 2013/10/29 21:11:39 This should have a comment explaining both extensi
Fady Samuel 2013/10/30 19:48:52 I've refactored things a bit to make it so that ex
+ const std::string& extension_id,
Type view_type);
static GuestView* FromWebContents(content::WebContents* web_contents);
@@ -89,7 +90,8 @@ class GuestView : public content::BrowserPluginGuestDelegate {
int embedder_render_process_id() const { return embedder_render_process_id_; }
protected:
- explicit GuestView(content::WebContents* guest_web_contents);
+ GuestView(content::WebContents* guest_web_contents,
+ const std::string& extension_id);
virtual ~GuestView();
// Dispatches an event |event_name| to the embedder with the |event| fields.

Powered by Google App Engine
This is Rietveld 408576698