<webview>: Resolve relative paths as chrome-extension: URLs

chrome/browser/guestview/guestview.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUESTVIEW_GUESTVIEW_H_
 #define CHROME_BROWSER_GUESTVIEW_GUESTVIEW_H_
 
 #include <queue>
 
 #include "base/values.h"
@@ skipping 24 matching lines @@
 
     scoped_ptr<DictionaryValue> GetArguments();
 
    private:
     const std::string event_name_;
     scoped_ptr<DictionaryValue> args_;
   };
 
   static Type GetViewTypeFromString(const std::string& api_type);
 
   static GuestView* Create(content::WebContents* guest_web_contents,

[Charlie Reis, 2013/10/29 21:11:39]

This should have a comment explaining both extension_id (and what it means for
it to be empty) and view_type.  For example, explain that an empty extension ID
will be set to a real value in Attach.

[Fady Samuel, 2013/10/30 19:48:52]

I've refactored things a bit to make it so that extension_id is always passed
in. In fact, this reduces code complexity quite a bit.

+                           const std::string& extension_id,
                            Type view_type);
 
   static GuestView* FromWebContents(content::WebContents* web_contents);
 
   static GuestView* From(int embedder_process_id, int instance_id);
 
   virtual void Attach(content::WebContents* embedder_web_contents,
                       const std::string& extension_id,
                       const base::DictionaryValue& args);
 
@@ skipping 26 matching lines @@
   // Returns the extension ID of the embedder.
   const std::string& extension_id() const { return extension_id_; }
 
   // Returns the user browser context of the embedder.
   content::BrowserContext* browser_context() const { return browser_context_; }
 
   // Returns the embedder's process ID.
   int embedder_render_process_id() const { return embedder_render_process_id_; }
 
  protected:
-  explicit GuestView(content::WebContents* guest_web_contents);
+  GuestView(content::WebContents* guest_web_contents,
+            const std::string& extension_id);
   virtual ~GuestView();
 
   // Dispatches an event |event_name| to the embedder with the |event| fields.
   void DispatchEvent(Event* event);
 
  private:
   void SendQueuedEvents();
 
   content::WebContents* guest_web_contents_;
   content::WebContents* embedder_web_contents_;
   std::string extension_id_;
   int embedder_render_process_id_;
   content::BrowserContext* browser_context_;
   // |guest_instance_id_| is a profile-wide unique identifier for a guest
   // WebContents.
   const int guest_instance_id_;
   // |view_instance_id_| is an identifier that's unique within a particular
   // embedder RenderViewHost for a particular <*view> instance.
   int view_instance_id_;
 
   // This is a queue of Events that are destined to be sent to the embedder once
   // the guest is attached to a particular embedder.
   std::queue<Event*> pending_events_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestView);
 };
 
 #endif  // CHROME_BROWSER_GUESTVIEW_GUESTVIEW_H_