Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Unified Diff: chrome/browser/guestview/webview/webview_guest.h

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor + addressed creis' comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/webview/webview_guest.h
diff --git a/chrome/browser/guestview/webview/webview_guest.h b/chrome/browser/guestview/webview/webview_guest.h
index 48e0ea4f75bc30ee8a6f2731bf1fc32c9a6bb322..ccfdab91d7b992e698e8b53c374bcd3820ac3882 100644
--- a/chrome/browser/guestview/webview/webview_guest.h
+++ b/chrome/browser/guestview/webview/webview_guest.h
@@ -26,14 +26,14 @@ class WebViewGuest : public GuestView,
public content::NotificationObserver,
public content::WebContentsObserver {
public:
- explicit WebViewGuest(content::WebContents* guest_web_contents);
+ WebViewGuest(content::WebContents* guest_web_contents,
+ const std::string& extension_id);
static WebViewGuest* From(int embedder_process_id, int instance_id);
static WebViewGuest* FromWebContents(content::WebContents* contents);
// GuestView implementation.
virtual void Attach(content::WebContents* embedder_web_contents,
- const std::string& extension_id,
const base::DictionaryValue& args) OVERRIDE;
virtual GuestView::Type GetViewType() const OVERRIDE;
virtual WebViewGuest* AsWebView() OVERRIDE;
@@ -62,6 +62,7 @@ class WebViewGuest : public GuestView,
const base::DictionaryValue& request_info,
const PermissionResponseCallback& callback,
bool allowed_by_default) OVERRIDE;
+ virtual GURL ResolveURL(const std::string& src) OVERRIDE;
virtual void SizeChanged(const gfx::Size& old_size, const gfx::Size& new_size)
OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698