Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 27408004: <webview>: Resolve relative paths as chrome-extension: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor + addressed creis' comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index ad4279cdbd0e4b0e8033e93ba70eb66d9e19eaea..5c175d3bcc3b2be9f20758de0a39ef8772ef162b 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -177,11 +177,6 @@ void BrowserPluginEmbedder::OnAttach(
BrowserPluginGuest* guest =
GetBrowserPluginGuestManager()->GetGuestByInstanceID(
instance_id, web_contents()->GetRenderProcessHost()->GetID());
-
- RenderProcessHost* render_process_host =
- web_contents()->GetRenderProcessHost();
- GURL validated_frame_url(params.embedder_frame_url);
Charlie Reis 2013/10/30 20:42:20 Are we using embedder_frame_url somewhere else?
Fady Samuel 2013/10/31 17:25:17 See BrowserPluginGuestManager::CreateGuest. The gu
- RenderViewHost::FilterURL(render_process_host, false, &validated_frame_url);
if (guest) {
// There is an implicit order expectation here:
@@ -192,7 +187,6 @@ void BrowserPluginEmbedder::OnAttach(
GetContentClient()->browser()->GuestWebContentsAttached(
guest->GetWebContents(),
web_contents(),
- validated_frame_url,
extra_params);
guest->Attach(
static_cast<WebContentsImpl*>(web_contents()), params, extra_params);
@@ -208,7 +202,6 @@ void BrowserPluginEmbedder::OnAttach(
GetContentClient()->browser()->GuestWebContentsAttached(
guest->GetWebContents(),
web_contents(),
- validated_frame_url,
extra_params);
guest->Initialize(static_cast<WebContentsImpl*>(web_contents()), params);
}

Powered by Google App Engine
This is Rietveld 408576698