Fix debugger regression in issue 28980

Fix debugger regression in issue 28980

When generating the implicit try-catch of an async function, use the
end token position of the function for the completeError() call. Before
this change, the position was one token past last function token.

CL https://codereview.chromium.org/2646093006/ introduced a regression.
This CL fixes #28980 and implements a different fix for #28443.

BUG=#28980
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/d8ddd7766b2520e8cda889ec01930181068aad40

[hausner, 2017-03-09 23:40:17]

Description was changed from

==========
Fix debugger regression in issue 28980

When generating the implicit try-catch of an async function, use the
end token position of the function for the completeError() call. Before
this change, the position was one token past last function token.

CL https://codereview.chromium.org/2646093006/ introduced a regression.
This CL fixes #28980 and implements a different fix for #28443.

BUG=#28980
==========

to

==========
Fix debugger regression in issue 28980

When generating the implicit try-catch of an async function, use the
end token position of the function for the completeError() call. Before
this change, the position was one token past last function token.

CL https://codereview.chromium.org/2646093006/ introduced a regression.
This CL fixes #28980 and implements a different fix for #28443.

BUG=#28980
==========

[hausner, 2017-03-09 23:40:17]

hausner@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-03-09 23:58:41]

Lgtm!

https://codereview.chromium.org/2740783007/diff/1/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/2740783007/diff/1/runtime/vm/parser.h#newcode670
runtime/vm/parser.h:670: TokenPosition fucnc_end_pos);
Typo: -> func_end_pos

[hausner, 2017-03-10 00:10:07]

https://codereview.chromium.org/2740783007/diff/1/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/2740783007/diff/1/runtime/vm/parser.h#newcode670
runtime/vm/parser.h:670: TokenPosition fucnc_end_pos);
On 2017/03/09 23:58:41, Florian Schneider wrote:
> Typo: -> func_end_pos

Done.

[hausner, 2017-03-10 00:20:52]

Description was changed from

==========
Fix debugger regression in issue 28980

When generating the implicit try-catch of an async function, use the
end token position of the function for the completeError() call. Before
this change, the position was one token past last function token.

CL https://codereview.chromium.org/2646093006/ introduced a regression.
This CL fixes #28980 and implements a different fix for #28443.

BUG=#28980
==========

to

==========
Fix debugger regression in issue 28980

When generating the implicit try-catch of an async function, use the
end token position of the function for the completeError() call. Before
this change, the position was one token past last function token.

CL https://codereview.chromium.org/2646093006/ introduced a regression.
This CL fixes #28980 and implements a different fix for #28443.

BUG=#28980
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d8ddd7766b2520e8cda889ec01930181068aad40
==========

[hausner, 2017-03-10 00:20:53]

Committed patchset #3 (id:40001) manually as
d8ddd7766b2520e8cda889ec01930181068aad40 (presubmit successful).