Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2646093006: Fix debugger's calculation of the context level in async code. (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
Cutch, hausner
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix debugger's calculation of the context level in async code. The synthetic call to completeError has the function end as a token position. This caused the < comparison to fail, and not find the correct context level when creating a stacktrace in the debugger. Fixes #28443 R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/3e59f95717f774f28b93634610abf24653b965f5

Patch Set 1 #

Patch Set 2 : remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
A runtime/observatory/tests/service/regress_28443_test.dart View 1 1 chunk +71 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 11 months ago (2017-01-20 23:00:43 UTC) #2
hausner
LGTM after offline discussion.
3 years, 11 months ago (2017-01-20 23:28:59 UTC) #3
Florian Schneider
3 years, 11 months ago (2017-01-21 00:08:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3e59f95717f774f28b93634610abf24653b965f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698