Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2740783002: Rename ShellBaseTestCase as WebShellTestCase. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org, michaeldo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ShellBaseTestCase as WebShellTestCase. The name doesn't need "Base" in it, and it should be "WebShell" to differentiate from "WebViewShell". BUG= Review-Url: https://codereview.chromium.org/2740783002 Cr-Commit-Position: refs/heads/master@{#455620} Committed: https://chromium.googlesource.com/chromium/src/+/90854585bebf660fbf80db77c8a9712eeba42968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -94 lines) Patch
M ios/web/shell/test/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/context_menu_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
D ios/web/shell/test/earl_grey/shell_base_test_case.h View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/web/shell/test/earl_grey/shell_base_test_case.mm View 1 chunk +0 lines, -57 lines 0 comments Download
A + ios/web/shell/test/earl_grey/web_shell_test_case.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + ios/web/shell/test/earl_grey/web_shell_test_case.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/meta_tags_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/navigation_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/page_state_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/pdf_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/plugin_placeholder_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/shell/test/redirect_egtest.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
There are some test helpers (e.g. shell_matchers) that start with shell. I think that should ...
3 years, 9 months ago (2017-03-08 23:02:51 UTC) #2
Eugene But (OOO till 7-30)
Thanks for cleanup! lgtm CCing michaeldo@
3 years, 9 months ago (2017-03-08 23:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740783002/1
3 years, 9 months ago (2017-03-08 23:43:34 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:19:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90854585bebf660fbf80db77c8a9...

Powered by Google App Engine
This is Rietveld 408576698