Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2740753002: Enable alignment unittests on iOS arm device builds. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable alignment unittests on iOS arm device builds. The underlying clang bugs causing misalignment of the data when the __attribute__((aligned(alignment))) was used with alignment values greater than 64 have been fixed, so re-enable the tests. BUG=138066, 349003 Review-Url: https://codereview.chromium.org/2740753002 Cr-Commit-Position: refs/heads/master@{#455519} Committed: https://chromium.googlesource.com/chromium/src/+/54069df248fa82893cda255d91c1704e01ea00a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M base/memory/aligned_memory_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sdefresne
Please take a look. I've tested that those tests pass on both armv7 and arm64 ...
3 years, 9 months ago (2017-03-08 19:14:04 UTC) #3
Nico
the second bug sounds like this requires xcode 8.2. do all your bots have that? ...
3 years, 9 months ago (2017-03-08 19:29:52 UTC) #7
sdefresne
On 2017/03/08 19:29:52, Nico wrote: > the second bug sounds like this requires xcode 8.2. ...
3 years, 9 months ago (2017-03-08 19:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740753002/1
3 years, 9 months ago (2017-03-08 19:44:33 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 19:50:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54069df248fa82893cda255d91c1...

Powered by Google App Engine
This is Rietveld 408576698