Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2740683004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, alemate+watch_chromium.org, tburkard+watch_chromium.org, achuith+watch_chromium.org, net-reviews_chromium.org, gavinp+prer_chromium.org, vabr+watchlistlogin_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (domain_reliability, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=davidben@chromium.org Review-Url: https://codereview.chromium.org/2740683004 Cr-Commit-Position: refs/heads/master@{#455597} Committed: https://chromium.googlesource.com/chromium/src/+/2314fa58a0d4e63203d65afb4e5c6502f1f036cd

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 16

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/domain_reliability/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/login/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/about_handler/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/domain_reliability/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/navigation_metrics/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ssl_config/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/third_party/nss/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/boringssl/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/tlslite/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-08 21:29:14 UTC) #2
ymzhang1
updated component in components/navigation_metrics/OWNERS
3 years, 9 months ago (2017-03-08 21:33:22 UTC) #4
davidben
https://codereview.chromium.org/2740683004/diff/40001/chrome/browser/domain_reliability/OWNERS File chrome/browser/domain_reliability/OWNERS (right): https://codereview.chromium.org/2740683004/diff/40001/chrome/browser/domain_reliability/OWNERS#newcode7 chrome/browser/domain_reliability/OWNERS:7: # COMPONENT: UI>OSIntegration Internals>Network https://codereview.chromium.org/2740683004/diff/40001/chrome/browser/ui/login/OWNERS File chrome/browser/ui/login/OWNERS (right): https://codereview.chromium.org/2740683004/diff/40001/chrome/browser/ui/login/OWNERS#newcode5 ...
3 years, 9 months ago (2017-03-08 21:40:14 UTC) #5
ymzhang1
https://codereview.chromium.org/2740683004/diff/40001/chrome/browser/domain_reliability/OWNERS File chrome/browser/domain_reliability/OWNERS (right): https://codereview.chromium.org/2740683004/diff/40001/chrome/browser/domain_reliability/OWNERS#newcode7 chrome/browser/domain_reliability/OWNERS:7: # COMPONENT: UI>OSIntegration On 2017/03/08 21:40:13, davidben wrote: > ...
3 years, 9 months ago (2017-03-08 21:46:33 UTC) #6
davidben
lgtm
3 years, 9 months ago (2017-03-08 21:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740683004/60001
3 years, 9 months ago (2017-03-08 21:51:04 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 23:44:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2314fa58a0d4e63203d65afb4e5c...

Powered by Google App Engine
This is Rietveld 408576698