Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2740683003: Add chrome://flags entry for MojoLoading (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://flags entry for MojoLoading BUG=603396 Review-Url: https://codereview.chromium.org/2740683003 Cr-Commit-Position: refs/heads/master@{#457002} Committed: https://chromium.googlesource.com/chromium/src/+/22bb91064201f266b30318b434d1cddf11f1c862

Patch Set 1 #

Patch Set 2 : +histogram #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : . #

Patch Set 6 : rebase #

Patch Set 7 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (34 generated)
tzik
PTAL
3 years, 9 months ago (2017-03-13 13:33:06 UTC) #20
Alexei Svitkine (slow)
https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histograms/histograms.xml#newcode98975 tools/metrics/histograms/histograms.xml:98975: + <int value="-1715425371" label="enable-mojo-loading"/> I don't think this is ...
3 years, 9 months ago (2017-03-13 15:04:21 UTC) #21
yhirano
lgtm
3 years, 9 months ago (2017-03-14 05:44:18 UTC) #22
tzik
https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histograms/histograms.xml#newcode98975 tools/metrics/histograms/histograms.xml:98975: + <int value="-1715425371" label="enable-mojo-loading"/> On 2017/03/13 15:04:21, Alexei Svitkine ...
3 years, 9 months ago (2017-03-14 10:50:47 UTC) #24
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-03-14 14:48:53 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740683003/100001
3 years, 9 months ago (2017-03-15 03:49:13 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/407134)
3 years, 9 months ago (2017-03-15 04:02:38 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740683003/120001
3 years, 9 months ago (2017-03-15 04:37:46 UTC) #40
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 05:34:09 UTC) #43
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/22bb91064201f266b30318b434d1...

Powered by Google App Engine
This is Rietveld 408576698