|
|
Chromium Code Reviews
DescriptionAdd chrome://flags entry for MojoLoading
BUG=603396
Review-Url: https://codereview.chromium.org/2740683003
Cr-Commit-Position: refs/heads/master@{#457002}
Committed: https://chromium.googlesource.com/chromium/src/+/22bb91064201f266b30318b434d1cddf11f1c862
Patch Set 1 #Patch Set 2 : +histogram #Patch Set 3 : fix #Patch Set 4 : rebase #
Total comments: 2
Patch Set 5 : . #Patch Set 6 : rebase #Patch Set 7 : fix #
Messages
Total messages: 43 (34 generated)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add chrome://flags entry for MojoLoading BUG= ========== to ========== Add chrome://flags entry for MojoLoading BUG=603396 ==========
tzik@chromium.org changed reviewers: + yhirano@chromium.org
tzik@chromium.org changed reviewers: + asvitkine@chromium.org
PTAL
https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:98975: + <int value="-1715425371" label="enable-mojo-loading"/> I don't think this is needed. The other two, yes.
lgtm
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2740683003/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:98975: + <int value="-1715425371" label="enable-mojo-loading"/> On 2017/03/13 15:04:21, Alexei Svitkine (very slow) wrote: > I don't think this is needed. The other two, yes. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org, asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/2740683003/#ps100001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from asvitkine@chromium.org, yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2740683003/#ps120001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489552650881480,
"parent_rev": "84188b5c73a3bd70944aac7028dbdd449e9e5b73", "commit_rev":
"22bb91064201f266b30318b434d1cddf11f1c862"}
Message was sent while issue was closed.
Description was changed from ========== Add chrome://flags entry for MojoLoading BUG=603396 ========== to ========== Add chrome://flags entry for MojoLoading BUG=603396 Review-Url: https://codereview.chromium.org/2740683003 Cr-Commit-Position: refs/heads/master@{#457002} Committed: https://chromium.googlesource.com/chromium/src/+/22bb91064201f266b30318b434d1... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/22bb91064201f266b30318b434d1... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
