Index: ios/chrome/browser/notification_promo_unittest.cc |
diff --git a/ios/chrome/browser/notification_promo_unittest.cc b/ios/chrome/browser/notification_promo_unittest.cc |
index 830d9c5f65a02412b9a60cd4a6e142bd19bb47d9..8ffe4bf57e9de2393d0f029f8e7f65dd5215e8a2 100644 |
--- a/ios/chrome/browser/notification_promo_unittest.cc |
+++ b/ios/chrome/browser/notification_promo_unittest.cc |
@@ -31,21 +31,19 @@ const char kDateFormat[] = "dd MMM yyyy HH:mm:ss zzzz"; |
bool YearFromNow(double* date_epoch, std::string* date_string) { |
*date_epoch = (base::Time::Now() + base::TimeDelta::FromDays(365)).ToTimeT(); |
+ // TODO(jungshik): Use an ICU date formatter wrapper if it's ok to depend |
sdefresne
2017/03/15 08:57:59
For ios/ code we prefer to have TODO use the forma
|
+ // on base::i18n. |
UErrorCode status = U_ZERO_ERROR; |
icu::SimpleDateFormat simple_formatter(icu::UnicodeString(kDateFormat), |
icu::Locale("en_US"), status); |
- if (!U_SUCCESS(status)) |
- return false; |
- |
icu::UnicodeString date_unicode_string; |
simple_formatter.format(static_cast<UDate>(*date_epoch * 1000), |
date_unicode_string, status); |
- if (!U_SUCCESS(status)) |
+ if (U_FAILURE(status)) |
return false; |
- return base::UTF16ToUTF8(date_unicode_string.getBuffer(), |
- static_cast<size_t>(date_unicode_string.length()), |
- date_string); |
+ date_unicode_string.toUTF8String(*date_string); |
+ return true; |
} |
} // namespace |