Prepare Chromium and Blink for ICU 59

ios/chrome/browser/notification_promo_unittest.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/json/json_reader.h"
@@ skipping 13 matching lines @@
 
 namespace ios {
 
 namespace {
 
 const char kDateFormat[] = "dd MMM yyyy HH:mm:ss zzzz";
 
 bool YearFromNow(double* date_epoch, std::string* date_string) {
   *date_epoch = (base::Time::Now() + base::TimeDelta::FromDays(365)).ToTimeT();
 
+  // TODO(jungshik): Use an ICU date formatter wrapper if it's ok to depend

[sdefresne, 2017/03/15 08:57:59]

For ios/ code we prefer to have TODO use the format TODO(crbug.com/xxxxxx) where
xxxxxx is the id of the bug used to track fixing the TODO.

Regarding the TODO itself, it is okay to depends on base/i18n here.

+  // on base::i18n.
   UErrorCode status = U_ZERO_ERROR;
   icu::SimpleDateFormat simple_formatter(icu::UnicodeString(kDateFormat),
                                          icu::Locale("en_US"), status);
-  if (!U_SUCCESS(status))
-    return false;
-
   icu::UnicodeString date_unicode_string;
   simple_formatter.format(static_cast<UDate>(*date_epoch * 1000),
                           date_unicode_string, status);
-  if (!U_SUCCESS(status))
+  if (U_FAILURE(status))
     return false;
 
-  return base::UTF16ToUTF8(date_unicode_string.getBuffer(),
-                           static_cast<size_t>(date_unicode_string.length()),
-                           date_string);
+  date_unicode_string.toUTF8String(*date_string);
+  return true;
 }
 
 }  // namespace
 
 class NotificationPromoTest : public testing::Test {
  public:
   NotificationPromoTest()
       : notification_promo_(&local_state_),
         field_trial_list_(base::MakeUnique<base::FieldTrialList>(
             base::MakeUnique<base::MockEntropyProvider>())),
@@ skipping 382 matching lines @@
       "  \"promo_id\":0"
       "}",
       "What do you think of Chrome?",
       933672366,  // unix epoch for 3 Aug 1999 9:26:06 GMT.
       0, 30, 30);
   InitPromoFromVariations();
   TestMigrationOfOldPrefs();
 }
 
 }  // namespace ios