Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: components/autofill/core/browser/autofill_experiments.cc

Issue 2740633002: [Autofill] Add upstreaming UKM (Closed)
Patch Set: Addressed comments + feature flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_experiments.cc
diff --git a/components/autofill/core/browser/autofill_experiments.cc b/components/autofill/core/browser/autofill_experiments.cc
index 8e0c3a7458d3469ddec034d88db86af5e04e76b7..6fa341f14afba3dd4a3b96bfaeaea91c46b3e22d 100644
--- a/components/autofill/core/browser/autofill_experiments.cc
+++ b/components/autofill/core/browser/autofill_experiments.cc
@@ -32,6 +32,8 @@ const base::Feature kAutofillCreditCardPopupLayout{
"AutofillCreditCardPopupLayout", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kAutofillCreditCardLastUsedDateDisplay{
"AutofillCreditCardLastUsedDateDisplay", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kAutofillUkmLogging{"AutofillLogUkm",
Mathieu 2017/03/09 20:13:26 AutofillUkmLogging is also a good feature name
sebsg 2017/03/09 20:52:16 Done.
+ base::FEATURE_DISABLED_BY_DEFAULT};
const char kCreditCardSigninPromoImpressionLimitParamKey[] = "impression_limit";
const char kAutofillCreditCardPopupBackgroundColorKey[] = "background_color";
const char kAutofillCreditCardPopupDividerColorKey[] = "dropdown_divider_color";
@@ -223,4 +225,8 @@ bool IsCreditCardUploadEnabled(const PrefService* pref_service,
return !group_name.empty() && group_name != "Disabled";
}
+bool IsLoggingUkmEnabled() {
+ return base::FeatureList::IsEnabled(kAutofillUkmLogging);
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698