Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Side by Side Diff: components/autofill/core/browser/autofill_experiments.cc

Issue 2740633002: [Autofill] Add upstreaming UKM (Closed)
Patch Set: Addressed comments + feature flag Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_experiments.h" 5 #include "components/autofill/core/browser/autofill_experiments.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 14 matching lines...) Expand all
25 namespace autofill { 25 namespace autofill {
26 26
27 const base::Feature kAutofillCreditCardAssist{ 27 const base::Feature kAutofillCreditCardAssist{
28 "AutofillCreditCardAssist", base::FEATURE_DISABLED_BY_DEFAULT}; 28 "AutofillCreditCardAssist", base::FEATURE_DISABLED_BY_DEFAULT};
29 const base::Feature kAutofillScanCardholderName{ 29 const base::Feature kAutofillScanCardholderName{
30 "AutofillScanCardholderName", base::FEATURE_DISABLED_BY_DEFAULT}; 30 "AutofillScanCardholderName", base::FEATURE_DISABLED_BY_DEFAULT};
31 const base::Feature kAutofillCreditCardPopupLayout{ 31 const base::Feature kAutofillCreditCardPopupLayout{
32 "AutofillCreditCardPopupLayout", base::FEATURE_DISABLED_BY_DEFAULT}; 32 "AutofillCreditCardPopupLayout", base::FEATURE_DISABLED_BY_DEFAULT};
33 const base::Feature kAutofillCreditCardLastUsedDateDisplay{ 33 const base::Feature kAutofillCreditCardLastUsedDateDisplay{
34 "AutofillCreditCardLastUsedDateDisplay", base::FEATURE_DISABLED_BY_DEFAULT}; 34 "AutofillCreditCardLastUsedDateDisplay", base::FEATURE_DISABLED_BY_DEFAULT};
35 const base::Feature kAutofillUkmLogging{"AutofillLogUkm",
Mathieu 2017/03/09 20:13:26 AutofillUkmLogging is also a good feature name
sebsg 2017/03/09 20:52:16 Done.
36 base::FEATURE_DISABLED_BY_DEFAULT};
35 const char kCreditCardSigninPromoImpressionLimitParamKey[] = "impression_limit"; 37 const char kCreditCardSigninPromoImpressionLimitParamKey[] = "impression_limit";
36 const char kAutofillCreditCardPopupBackgroundColorKey[] = "background_color"; 38 const char kAutofillCreditCardPopupBackgroundColorKey[] = "background_color";
37 const char kAutofillCreditCardPopupDividerColorKey[] = "dropdown_divider_color"; 39 const char kAutofillCreditCardPopupDividerColorKey[] = "dropdown_divider_color";
38 const char kAutofillCreditCardPopupValueBoldKey[] = "is_value_bold"; 40 const char kAutofillCreditCardPopupValueBoldKey[] = "is_value_bold";
39 const char kAutofillCreditCardPopupIsValueAndLabelInSingleLineKey[] = 41 const char kAutofillCreditCardPopupIsValueAndLabelInSingleLineKey[] =
40 "is_value_and_label_in_single_line"; 42 "is_value_and_label_in_single_line";
41 const char kAutofillPopupDropdownItemHeightKey[] = "dropdown_item_height"; 43 const char kAutofillPopupDropdownItemHeightKey[] = "dropdown_item_height";
42 const char kAutofillCreditCardPopupIsIconAtStartKey[] = 44 const char kAutofillCreditCardPopupIsIconAtStartKey[] =
43 "is_credit_card_icon_at_start"; 45 "is_credit_card_icon_at_start";
44 const char kAutofillPopupMarginKey[] = "margin"; 46 const char kAutofillPopupMarginKey[] = "margin";
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 return true; 218 return true;
217 } 219 }
218 if (base::CommandLine::ForCurrentProcess()->HasSwitch( 220 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
219 switches::kDisableOfferUploadCreditCards)) { 221 switches::kDisableOfferUploadCreditCards)) {
220 return false; 222 return false;
221 } 223 }
222 224
223 return !group_name.empty() && group_name != "Disabled"; 225 return !group_name.empty() && group_name != "Disabled";
224 } 226 }
225 227
228 bool IsLoggingUkmEnabled() {
229 return base::FeatureList::IsEnabled(kAutofillUkmLogging);
230 }
231
226 } // namespace autofill 232 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698