[inspector] added length for scriptParsed notification

[inspector] added length for scriptParsed notification

BUG=none
R=caseq@chromium.org

Review-Url: https://codereview.chromium.org/2740623002
Cr-Commit-Position: refs/heads/master@{#43656}
Committed: https://chromium.googlesource.com/v8/v8/+/07ada64a57fa566cffd610133821f0c29eac301a

[kozy, 2017-03-07 21:09:56]

Patchset #1 (id:1) has been deleted

[kozy, 2017-03-07 21:10:30]

Andrey, please take a look!

[kozy, 2017-03-07 21:10:46]

Description was changed from

==========
[inspector] added length for scriptParsed notification

BUG=none
R=caseq@chromium.org
==========

to

==========
[inspector] added length for scriptParsed notification

BUG=none
R=caseq@chromium.org
==========

[kozy, 2017-03-07 21:10:46]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2017-03-07 21:11:11]

+ Dmitry, I need owner lgtm for js_protocol.json.

[caseq, 2017-03-07 21:25:36]

lgtm

https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
File src/inspector/js_protocol.json (right):

https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
src/inspector/js_protocol.json:716: { "name": "length", "type": "integer",
"optional": true, "description": "This script length.", "experimental": true }
drop "optional", perhaps?

[dgozman, 2017-03-07 21:27:56]

lgtm

https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
File src/inspector/js_protocol.json (right):

https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
src/inspector/js_protocol.json:716: { "name": "length", "type": "integer",
"optional": true, "description": "This script length.", "experimental": true }
On 2017/03/07 21:25:36, caseq wrote:
> drop "optional", perhaps?

Let's not. This way we don't guarantee anything and can revisit in the future.

[kozy, 2017-03-07 21:30:28]

Patchset #2 (id:40001) has been deleted

[caseq, 2017-03-07 21:32:48]

On 2017/03/07 21:27:56, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
> File src/inspector/js_protocol.json (right):
> 
>
https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
> src/inspector/js_protocol.json:716: { "name": "length", "type": "integer",
> "optional": true, "description": "This script length.", "experimental": true }
> On 2017/03/07 21:25:36, caseq wrote:
> > drop "optional", perhaps?
> 
> Let's not. This way we don't guarantee anything and can revisit in the future.

But that's what "experimental" is there for :-)

[kozy, 2017-03-07 21:34:24]

https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
File src/inspector/js_protocol.json (right):

https://codereview.chromium.org/2740623002/diff/20001/src/inspector/js_protoc...
src/inspector/js_protocol.json:716: { "name": "length", "type": "integer",
"optional": true, "description": "This script length.", "experimental": true }
On 2017/03/07 21:25:36, caseq wrote:
> drop "optional", perhaps?

I prefer to land as optional, otherwise it requires additional preparation work
on frontend to make at least closure compiler happy.

[kozy, 2017-03-07 21:34:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-03-07 21:34:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:01:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488922468940020,
"parent_rev": "f774d8c56f00de92614886fc4cb541411eff7aa1", "commit_rev":
"07ada64a57fa566cffd610133821f0c29eac301a"}

[commit-bot: I haz the power, 2017-03-07 22:01:44]

Description was changed from

==========
[inspector] added length for scriptParsed notification

BUG=none
R=caseq@chromium.org
==========

to

==========
[inspector] added length for scriptParsed notification

BUG=none
R=caseq@chromium.org

Review-Url: https://codereview.chromium.org/2740623002
Cr-Commit-Position: refs/heads/master@{#43656}
Committed:
https://chromium.googlesource.com/v8/v8/+/07ada64a57fa566cffd610133821f0c29ea...
==========

[commit-bot: I haz the power, 2017-03-07 22:01:45]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/07ada64a57fa566cffd610133821f0c29ea...