Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 2740603003: Hide SpellCheckRequest from other classes in editing/spellcheck (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
index 2f92d767d3981f5eda9c7a6451c97e8c632d0c57..fe5cf138485f8478fd05c836ff49b9639c678e18 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
@@ -143,7 +143,13 @@ void SpellCheckRequester::timerFiredToProcessQueuedRequest(TimerBase*) {
invokeRequest(m_requestQueue.takeFirst());
}
-void SpellCheckRequester::requestCheckingFor(SpellCheckRequest* request) {
+void SpellCheckRequester::requestCheckingFor(const EphemeralRange& range) {
+ requestCheckingFor(range, 0);
+}
+
+void SpellCheckRequester::requestCheckingFor(const EphemeralRange& range,
+ int requestNum) {
+ SpellCheckRequest* request = SpellCheckRequest::create(range, requestNum);
yosin_UTC9 2017/03/09 01:28:15 nit: s/SpellCheckRequest*/SpellCheckRequest* const
Xiaocheng 2017/03/10 23:13:22 SpellCheckRequest::ctor checks if the range is nul
if (!request)
return;

Powered by Google App Engine
This is Rietveld 408576698