Hide SpellCheckRequest from other classes in editing/spellcheck

third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 125 matching lines @@
 }
 
 void SpellCheckRequester::timerFiredToProcessQueuedRequest(TimerBase*) {
   DCHECK(!m_requestQueue.isEmpty());
   if (m_requestQueue.isEmpty())
     return;
 
   invokeRequest(m_requestQueue.takeFirst());
 }
 
-void SpellCheckRequester::requestCheckingFor(SpellCheckRequest* request) {
+void SpellCheckRequester::requestCheckingFor(const EphemeralRange& range) {
+  requestCheckingFor(range, 0);
+}
+
+void SpellCheckRequester::requestCheckingFor(const EphemeralRange& range,
+                                             int requestNum) {
+  SpellCheckRequest* request = SpellCheckRequest::create(range, requestNum);

[yosin_UTC9, 2017/03/09 01:28:15]

nit: s/SpellCheckRequest*/SpellCheckRequest* const/

Please add |DCHECK(!range.isNull())|.

[Xiaocheng, 2017/03/10 23:13:22]

SpellCheckRequest::ctor checks if the range is null.

Not sure if the current callers pass null ranges, and don't want to change the
code now...

   if (!request)
     return;
 
   DCHECK_EQ(request->data().sequence(), unrequestedTextCheckingSequence);
   int sequence = ++m_lastRequestSequence;
   if (sequence == unrequestedTextCheckingSequence)
     sequence = ++m_lastRequestSequence;
 
   request->setCheckerAndSequence(this, sequence);
 
@@ skipping 113 matching lines @@
   didCheck(sequence, results);
 }
 
 DEFINE_TRACE(SpellCheckRequester) {
   visitor->trace(m_frame);
   visitor->trace(m_processingRequest);
   visitor->trace(m_requestQueue);
 }
 
 }  // namespace blink