Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Issue 2740603002: [Merge M58] arc: Handle position conflict in app list items. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arc: Handle position conflict in app list items. It is not guaranteed that sync items have unique positions. This may cause crash in case web store app has conflicting pos with some other app. TEST=Unit test added BUG=692802 NOTRY=true NOPRESUBMIT=true TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2732633003 Cr-Commit-Position: refs/heads/master@{#455195} (cherry picked from commit 11f9ee62d5cb9fbc3d3f1458e145b06be67f78ae) Review-Url: https://codereview.chromium.org/2740603002 Cr-Commit-Position: refs/branch-heads/3029@{#51} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/651a2d0a721ad7779451275b595ba3ad30d3a3c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -21 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 4 chunks +42 lines, -21 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc View 1 chunk +133 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740603002/1
3 years, 9 months ago (2017-03-07 20:29:32 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:43:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/651a2d0a721ad7779451275b595b...

Powered by Google App Engine
This is Rietveld 408576698