chrome/browser/ui/login/login_handler.cc - Issue 2740523002: [Password Manager] Fix saving for accounts.google.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_handler.cc

Issue 2740523002: [Password Manager] Fix saving for accounts.google.com. (Closed)

Patch Set: Small coments fixes Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/login/login_handler.cc

diff --git a/chrome/browser/ui/login/login_handler.cc b/chrome/browser/ui/login/login_handler.cc

index 86565bca97f4488fb6986afa54c145c1cd645c57..48caf6ffb78babddf801ddcd53952035a4d5dc82 100644

--- a/chrome/browser/ui/login/login_handler.cc

+++ b/chrome/browser/ui/login/login_handler.cc

@@ -193,7 +193,7 @@ void LoginHandler::SetAuth(const base::string16& username,

if (password_manager_) {

password_form_.username_value = username;

password_form_.password_value = password;

- password_manager_->ProvisionallySavePassword(password_form_);

+ password_manager_->ProvisionallySavePassword(password_form_, nullptr);

if (logger) {

logger->LogPasswordForm(

autofill::SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM,

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »