Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: chrome/browser/ui/login/login_handler.cc

Issue 2740523002: [Password Manager] Fix saving for accounts.google.com. (Closed)
Patch Set: Small coments fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/login/login_handler.h" 5 #include "chrome/browser/ui/login/login_handler.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 autofill::SavePasswordProgressLogger::STRING_AUTHENTICATION_HANDLED, 186 autofill::SavePasswordProgressLogger::STRING_AUTHENTICATION_HANDLED,
187 already_handled); 187 already_handled);
188 } 188 }
189 if (already_handled) 189 if (already_handled)
190 return; 190 return;
191 191
192 // Tell the password manager the credentials were submitted / accepted. 192 // Tell the password manager the credentials were submitted / accepted.
193 if (password_manager_) { 193 if (password_manager_) {
194 password_form_.username_value = username; 194 password_form_.username_value = username;
195 password_form_.password_value = password; 195 password_form_.password_value = password;
196 password_manager_->ProvisionallySavePassword(password_form_); 196 password_manager_->ProvisionallySavePassword(password_form_, nullptr);
197 if (logger) { 197 if (logger) {
198 logger->LogPasswordForm( 198 logger->LogPasswordForm(
199 autofill::SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM, 199 autofill::SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM,
200 password_form_); 200 password_form_);
201 } 201 }
202 } 202 }
203 203
204 // Calling NotifyAuthSupplied() directly instead of posting a task 204 // Calling NotifyAuthSupplied() directly instead of posting a task
205 // allows other LoginHandler instances to queue their 205 // allows other LoginHandler instances to queue their
206 // CloseContentsDeferred() before ours. Closing dialogs in the 206 // CloseContentsDeferred() before ours. Closing dialogs in the
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 bool is_main_frame = 662 bool is_main_frame =
663 (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0; 663 (request->load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0;
664 LoginHandler* handler = LoginHandler::Create(auth_info, request); 664 LoginHandler* handler = LoginHandler::Create(auth_info, request);
665 BrowserThread::PostTask( 665 BrowserThread::PostTask(
666 BrowserThread::UI, FROM_HERE, 666 BrowserThread::UI, FROM_HERE,
667 base::Bind(&LoginHandler::LoginDialogCallback, request->url(), 667 base::Bind(&LoginHandler::LoginDialogCallback, request->url(),
668 base::RetainedRef(auth_info), base::RetainedRef(handler), 668 base::RetainedRef(auth_info), base::RetainedRef(handler),
669 is_main_frame)); 669 is_main_frame));
670 return handler; 670 return handler;
671 } 671 }
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698