Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2740473003: Avoid fetching RFH from nav handle for not committed navigations. (Closed)

Created:
3 years, 9 months ago by lfg
Modified:
3 years, 9 months ago
Reviewers:
jam, dgozman, mharanczyk
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Avoid fetching RFH from nav handle for not committed navigations. For devtool use case there is only a need to check if hosts match, so compareing frame tree node id instead of raw pointers will give same result. BUG=697991 Review-Url: https://codereview.chromium.org/2730873002 Cr-Commit-Position: refs/heads/master@{#454849} (cherry picked from commit 9b5ea61b97315d1d028f440d6dc7defed009cf66) TBR=jam@chromium.org,dgozman@chromium.org,mharanczyk@opera.com NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2740473003 Cr-Commit-Position: refs/branch-heads/3029@{#50} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c1080fb57cbca2367d947ce94b4eddba499c98a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740473003/1
3 years, 9 months ago (2017-03-07 19:43:17 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 20:06:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1080fb57cbca2367d947ce94b4e...

Powered by Google App Engine
This is Rietveld 408576698