DownloadManagerController now uses WebState

ios/chrome/browser/tabs/tab.mm

Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index bb7f69a41d35c8f56349c2158c41943304301f82..f65d7c105563e52a7f2d8499ce703789f181f0b6 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1451,17 +1451,9 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
 }
 
 - (id<CRWNativeContent>)controllerForUnhandledContentAtURL:(const GURL&)url {
-  StoreKitTabHelper* helper = StoreKitTabHelper::FromWebState(self.webState);
-  if (!helper)
-    return nil;
-  id<StoreKitLauncher> storeKitLauncher = helper->GetLauncher();
-  if (!storeKitLauncher)
-    return nil;

[rohitrao (ping after 24h), 2017/03/07 13:51:22]

There is a small logic change here, in that the old code would not open the
download controller at all if there was no storekit launcher.  The new code will
open the download controller but do nothing when you try to go to the app store.

Nothing needs to be changed here, we should just be aware of the change.

[pkl (ping after 24h if needed), 2017/03/07 22:22:01]

I added a check to download manager controller to not bring up the UI if
StoreKitTabHelper is nil.

   DownloadManagerController* downloadController =
-      [[[DownloadManagerController alloc]
-                   initWithURL:url
-          requestContextGetter:browserState_->GetRequestContext()
-              storeKitLauncher:storeKitLauncher] autorelease];
+      [[[DownloadManagerController alloc] initWithWebState:self.webState

[rohitrao (ping after 24h), 2017/03/07 13:51:22]

This addresses the "followup" comments that I left on the other CL =)

[pkl (ping after 24h if needed), 2017/03/07 22:07:19]

Acknowledged.

+                                               downloadURL:url] autorelease];
   [downloadController start];
   return downloadController;
 }