DownloadManagerController now uses WebState

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 1433 matching lines @@
 - (void)closeThisTab {
   if (!parentTabModel_)
     return;
 
   NSUInteger index = [parentTabModel_ indexOfTab:self];
   if (index != NSNotFound)
     [parentTabModel_ closeTabAtIndex:index];
 }
 
 - (id<CRWNativeContent>)controllerForUnhandledContentAtURL:(const GURL&)url {
-  StoreKitTabHelper* helper = StoreKitTabHelper::FromWebState(self.webState);
-  if (!helper)
-    return nil;
-  id<StoreKitLauncher> storeKitLauncher = helper->GetLauncher();
-  if (!storeKitLauncher)
-    return nil;

[rohitrao (ping after 24h), 2017/03/07 13:51:22]

There is a small logic change here, in that the old code would not open the
download controller at all if there was no storekit launcher.  The new code will
open the download controller but do nothing when you try to go to the app store.

Nothing needs to be changed here, we should just be aware of the change.

[pkl (ping after 24h if needed), 2017/03/07 22:22:01]

I added a check to download manager controller to not bring up the UI if
StoreKitTabHelper is nil.

   DownloadManagerController* downloadController =
-      [[[DownloadManagerController alloc]
-                   initWithURL:url
-          requestContextGetter:browserState_->GetRequestContext()
-              storeKitLauncher:storeKitLauncher] autorelease];
+      [[[DownloadManagerController alloc] initWithWebState:self.webState

[rohitrao (ping after 24h), 2017/03/07 13:51:22]

This addresses the "followup" comments that I left on the other CL =)

[pkl (ping after 24h if needed), 2017/03/07 22:07:19]

Acknowledged.

+                                               downloadURL:url] autorelease];
   [downloadController start];
   return downloadController;
 }
 
 - (void)handleExportableFile:(net::HttpResponseHeaders*)headers {
   // Only "application/pdf" is supported for now.
   if (self.webState->GetContentsMimeType() != "application/pdf")
     return;
 
   [[NSNotificationCenter defaultCenter]
@@ skipping 767 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end