Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2740453002: Allow import of .gitignore from wpt. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow import of .gitignore from wpt. BUG=698904 Review-Url: https://codereview.chromium.org/2740453002 Cr-Commit-Position: refs/heads/master@{#455035} Committed: https://chromium.googlesource.com/chromium/src/+/f3225a2da3211a2826edded5e442aba635f5f91b

Patch Set 1 #

Patch Set 2 : Don't remove .gitignore files. #

Total comments: 1

Patch Set 3 : For this CL, only allow in .gitignore files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
3 years, 9 months ago (2017-03-07 00:27:51 UTC) #3
jeffcarp
https://codereview.chromium.org/2740453002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py (right): https://codereview.chromium.org/2740453002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py#newcode143 third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py:143: if filename.startswith('.gitkeep') or filename.endswith('.pl'): As we talked about in ...
3 years, 9 months ago (2017-03-07 01:17:11 UTC) #4
jeffcarp
lgtm
3 years, 9 months ago (2017-03-07 04:08:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740453002/40001
3 years, 9 months ago (2017-03-07 04:21:45 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 05:11:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3225a2da3211a2826edded5e442...

Powered by Google App Engine
This is Rietveld 408576698