Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2740433003: [macros] Implement NUMBER_IS_NAN in terms of strict equality. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[macros] Implement NUMBER_IS_NAN in terms of strict equality. This slighty improves the Map/Set implementations in the new pipeline, which makes heavy use of NUMBER_IS_NAN. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2740433003 Cr-Commit-Position: refs/heads/master@{#43632} Committed: https://chromium.googlesource.com/v8/v8/+/8150cb2c3ca3cf968d2b12b6625bc73733bd40cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-07 10:12:13 UTC) #1
Jarin
lgtm
3 years, 9 months ago (2017-03-07 10:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740433003/1
3 years, 9 months ago (2017-03-07 10:14:27 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 10:39:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8150cb2c3ca3cf968d2b12b6625bc73733b...

Powered by Google App Engine
This is Rietveld 408576698