Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2740293002: Range: surroundContents() should not check detached CharacterData node beforehand. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Range: surroundContents() should not check detached CharacterData node beforehand. Our implementation had unnecessary precondition check for detached CharacterData, and it's not defined by the DOM standard. This CL removes it. * fast/dom/Range/31684.html: Removed This CL changes the exception message in this test. We remove this because It's well tested in WPT. BUG=700275 Review-Url: https://codereview.chromium.org/2740293002 Cr-Commit-Position: refs/heads/master@{#456037} Committed: https://chromium.googlesource.com/chromium/src/+/cfb61c80a7256f706df0fd62de61afd5c62ccb69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1725 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-surroundContents-expected.txt View 1 chunk +0 lines, -1676 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Range/31684.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Range/31684-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yosin@, would you review this please?
3 years, 9 months ago (2017-03-10 08:20:30 UTC) #5
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-10 10:45:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740293002/1
3 years, 9 months ago (2017-03-10 10:45:27 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 10:49:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfb61c80a7256f706df0fd62de61...

Powered by Google App Engine
This is Rietveld 408576698