Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2740283003:
MD Settings: String fixes. (Closed)
|
Created:
3 years, 9 months ago by scottchen Modified:
3 years, 9 months ago Reviewers:
dpapad CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: String fixes.
BUG=681232
Review-Url: https://codereview.chromium.org/2740283003
Cr-Commit-Position: refs/heads/master@{#456821}
Committed: https://chromium.googlesource.com/chromium/src/+/f53b9054835933b6dde71efdc6de3e485c356f20
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
scottchen@chromium.org changed reviewers: + dpapad@chromium.org
Is there a bug corresponding to this CL?
Description was changed from ========== MD Settings: text fixes. BUG= ========== to ========== MD Settings: text fixes. BUG=681232 ==========
On 2017/03/10 23:48:45, dpapad wrote: > Is there a bug corresponding to this CL? Yeah, I closed it too early since I missed a couple. Just edited the issue to include the bug number.
On 2017/03/13 at 17:20:13, scottchen wrote: > On 2017/03/10 23:48:45, dpapad wrote: > > Is there a bug corresponding to this CL? > > Yeah, I closed it too early since I missed a couple. Just edited the issue to include the bug number. The CL title says "test fixes" but I don't see any testing related code in this CL. Should it be "string fixes" or something like that?
On 2017/03/13 17:39:43, dpapad wrote: > On 2017/03/13 at 17:20:13, scottchen wrote: > > On 2017/03/10 23:48:45, dpapad wrote: > > > Is there a bug corresponding to this CL? > > > > Yeah, I closed it too early since I missed a couple. Just edited the issue to > include the bug number. > > The CL title says "test fixes" but I don't see any testing related code in this > CL. Should it be "string fixes" or something like that? It said "text" fixes haha. I'll change it to string fixes to avoid mis-reading.
Description was changed from ========== MD Settings: text fixes. BUG=681232 ========== to ========== BUG=681232 ==========
On 2017/03/13 at 18:00:33, scottchen wrote: > On 2017/03/13 17:39:43, dpapad wrote: > > On 2017/03/13 at 17:20:13, scottchen wrote: > > > On 2017/03/10 23:48:45, dpapad wrote: > > > > Is there a bug corresponding to this CL? > > > > > > Yeah, I closed it too early since I missed a couple. Just edited the issue to > > include the bug number. > > > > The CL title says "test fixes" but I don't see any testing related code in this > > CL. Should it be "string fixes" or something like that? > > It said "text" fixes haha. I'll change it to string fixes to avoid mis-reading. Ah, that makes sense. My brain somehow misread "text" over and over. LGTM
The CQ bit was checked by scottchen@chromium.org
Description was changed from ========== BUG=681232 ========== to ========== MD Settings: String fixes. BUG=681232 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489520815236410, "parent_rev":
"98ce837b8d9a000f7157f86def167b13e3d5be37", "commit_rev":
"f53b9054835933b6dde71efdc6de3e485c356f20"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: String fixes. BUG=681232 ========== to ========== MD Settings: String fixes. BUG=681232 Review-Url: https://codereview.chromium.org/2740283003 Cr-Commit-Position: refs/heads/master@{#456821} Committed: https://chromium.googlesource.com/chromium/src/+/f53b9054835933b6dde71efdc6de... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f53b9054835933b6dde71efdc6de... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
