Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2740273002: Remove unused SpellChecker::selectionStartHasSpellingMarkerFor (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused SpellChecker::selectionStartHasSpellingMarkerFor TEST=No change in behavior Review-Url: https://codereview.chromium.org/2740273002 Cr-Commit-Position: refs/heads/master@{#456007} Committed: https://chromium.googlesource.com/chromium/src/+/75fc67d070979f30b49c1b272c0d9c64211aa6e9

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yoichio
3 years, 9 months ago (2017-03-10 02:29:52 UTC) #5
yosin_UTC9
lgtm Please rebase.
3 years, 9 months ago (2017-03-10 03:39:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740273002/40001
3 years, 9 months ago (2017-03-10 04:36:42 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 06:12:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75fc67d070979f30b49c1b272c0d...

Powered by Google App Engine
This is Rietveld 408576698