Oilpan: Avoid declaring a destructor for garbage collected ListHashSet.

Oilpan: Avoid declaring a destructor for garbage collected ListHashSet.

R=erik.corry@gmail.com, tkent@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173746

[haraken, 2014-05-09 07:02:41]

LGTM

[tkent, 2014-05-09 07:10:52]

lgtm

[Erik Corry, 2014-05-09 07:46:02]

lgtm

https://codereview.chromium.org/274023002/diff/1/Source/core/html/forms/FormC...
File Source/core/html/forms/FormController.cpp (right):

https://codereview.chromium.org/274023002/diff/1/Source/core/html/forms/FormC...
Source/core/html/forms/FormController.cpp:382:
DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED()
You didn't put the class name in the ().  Does this compile?

[zerny-chromium, 2014-05-09 07:59:07]

Thanks for the reviews.

On 2014/05/09 07:46:02, Erik Corry wrote:
> DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED()
> You didn't put the class name in the ().  Does this compile?

Opps. Surprisingly it does compile for oilpan, but not for non-oilpan of course.

[zerny-chromium, 2014-05-09 08:01:04]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-05-09 08:02:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zerny@chromium.org/274023002/20001

[Mikhail, 2014-05-09 08:06:36]

lgtm

https://codereview.chromium.org/274023002/diff/20001/Source/wtf/ListHashSet.h
File Source/wtf/ListHashSet.h (right):

https://codereview.chromium.org/274023002/diff/20001/Source/wtf/ListHashSet.h...
Source/wtf/ListHashSet.h:679: ASSERT(!Allocator::isGarbageCollected);
think now it can be COMPILE_ASSERT

[wibling-chromium, 2014-05-09 08:17:33]

lgtm2

[commit-bot: I haz the power, 2014-05-09 08:24:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7054)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6797)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6301)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6771)

[commit-bot: I haz the power, 2014-05-09 08:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 08:38:26]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6306)

[zerny-chromium, 2014-05-09 09:19:47]

I've updated the CL so that the destruction base contains the AllocatorProvider
as a part object. The previous code did not work because of reverse order
cleanup which caused the allocator to be deleted before finalize() on the
derived class was called.

PTAL

https://codereview.chromium.org/274023002/diff/20001/Source/wtf/ListHashSet.h
File Source/wtf/ListHashSet.h (right):

https://codereview.chromium.org/274023002/diff/20001/Source/wtf/ListHashSet.h...
Source/wtf/ListHashSet.h:679: ASSERT(!Allocator::isGarbageCollected);
On 2014/05/09 08:06:36, mikhail.pozdnyakov wrote:
> think now it can be COMPILE_ASSERT

Done.

[Erik Corry, 2014-05-09 09:22:17]

LGTM

[zerny-chromium, 2014-05-09 09:30:57]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-05-09 09:32:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zerny@chromium.org/274023002/40001

[wibling-chromium, 2014-05-09 09:39:17]

lgtm

[commit-bot: I haz the power, 2014-05-09 11:48:47]

Change committed as 173746