Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: Source/core/html/forms/FormController.h

Issue 274023002: Oilpan: Avoid declaring a destructor for garbage collected ListHashSet. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: move m_allocator to dtor base Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/forms/FormController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/FormController.h
diff --git a/Source/core/html/forms/FormController.h b/Source/core/html/forms/FormController.h
index d2e15867f58510a618b95f7cac888c0e6ff61d36..be335fbba0f3ffa5f1bcf0fd9f1502fc712c1dde 100644
--- a/Source/core/html/forms/FormController.h
+++ b/Source/core/html/forms/FormController.h
@@ -74,10 +74,10 @@ inline void FormControlState::append(const String& value)
typedef HashMap<AtomicString, OwnPtr<SavedFormState> > SavedFormStateMap;
-class DocumentState : public RefCountedWillBeGarbageCollectedFinalized<DocumentState> {
+class DocumentState FINAL : public RefCountedWillBeGarbageCollected<DocumentState> {
+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(DocumentState);
public:
static PassRefPtrWillBeRawPtr<DocumentState> create();
- ~DocumentState();
void trace(Visitor*);
void addControl(HTMLFormControlElementWithState*);
@@ -89,7 +89,7 @@ private:
FormElementListHashSet m_formControls;
};
-class FormController : public NoBaseWillBeGarbageCollectedFinalized<FormController> {
+class FormController FINAL : public NoBaseWillBeGarbageCollectedFinalized<FormController> {
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
static PassOwnPtrWillBeRawPtr<FormController> create()
« no previous file with comments | « no previous file | Source/core/html/forms/FormController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698