[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file(
views, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2740203004
Cr-Commit-Position: refs/heads/master@{#456244}
Committed: https://chromium.googlesource.com/chromium/src/+/dd3c8c6e5537c766c0db2a05a1cb744f4b93bf19

[ymzhang1, 2017-03-10 22:42:20]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[msw, 2017-03-10 23:06:03]

lgtm with one minor comment

https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
File components/constrained_window/OWNERS (right):

https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
components/constrained_window/OWNERS:5: # COMPONENT: Internals>Views
This is probably okay as-is, but I think there might be non-views
implementations of constrained windows... There might not be a perfect crbug
component to put here, but if we can include multiple, the main consumer of
constrained windows is probably component:UI>Browser>Core

https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS
File services/ui/OWNERS (right):

https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS#newcode9
services/ui/OWNERS:9: # COMPONENT: UI
This should probably be:
# COMPONENT: MUS

[rjkroege, 2017-03-11 00:05:52]

On 2017/03/10 23:06:03, msw wrote:
> lgtm with one minor comment
> 
>
https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
> File components/constrained_window/OWNERS (right):
> 
>
https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
> components/constrained_window/OWNERS:5: # COMPONENT: Internals>Views
> This is probably okay as-is, but I think there might be non-views
> implementations of constrained windows... There might not be a perfect crbug
> component to put here, but if we can include multiple, the main consumer of
> constrained windows is probably component:UI>Browser>Core
> 
> https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS
> File services/ui/OWNERS (right):
> 
> https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS#newcode9
> services/ui/OWNERS:9: # COMPONENT: UI
> This should probably be:
> # COMPONENT: MUS

Given that we're suppose to be deprecating Component MUS, maybe internals>MUS?

[ymzhang1, 2017-03-11 01:03:12]

On 2017/03/11 00:05:52, rjkroege wrote:
> On 2017/03/10 23:06:03, msw wrote:
> > lgtm with one minor comment
> > 
> >
>
https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
> > File components/constrained_window/OWNERS (right):
> > 
> >
>
https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
> > components/constrained_window/OWNERS:5: # COMPONENT: Internals>Views
> > This is probably okay as-is, but I think there might be non-views
> > implementations of constrained windows... There might not be a perfect crbug
> > component to put here, but if we can include multiple, the main consumer of
> > constrained windows is probably component:UI>Browser>Core
> > 
> > https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS
> > File services/ui/OWNERS (right):
> > 
> >
https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS#newcode9
> > services/ui/OWNERS:9: # COMPONENT: UI
> > This should probably be:
> > # COMPONENT: MUS
> 
> Given that we're suppose to be deprecating Component MUS, maybe internals>MUS?

Updated with Internals>MUS. Thanks for pointing out.

[ymzhang1, 2017-03-11 01:03:18]

https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
File components/constrained_window/OWNERS (right):

https://codereview.chromium.org/2740203004/diff/1/components/constrained_wind...
components/constrained_window/OWNERS:5: # COMPONENT: Internals>Views
On 2017/03/10 23:06:03, msw wrote:
> This is probably okay as-is, but I think there might be non-views
> implementations of constrained windows... There might not be a perfect crbug
> component to put here, but if we can include multiple, the main consumer of
> constrained windows is probably component:UI>Browser>Core 

Thanks for the commit! We would like to add only one primary component in each
OWNER file. However, I will keep a record of  UI>Browser>Core for this
directory.

https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS
File services/ui/OWNERS (right):

https://codereview.chromium.org/2740203004/diff/1/services/ui/OWNERS#newcode9
services/ui/OWNERS:9: # COMPONENT: UI
On 2017/03/10 23:06:03, msw wrote:
> This should probably be:
> # COMPONENT: MUS 

Thanks for the comment. Updated with Internals>MUS.

[ymzhang1, 2017-03-11 01:03:34]

The CQ bit was checked by ymzhang@chromium.org

[ymzhang1, 2017-03-11 01:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2740203004/#ps20001
(title: "update component")

[commit-bot: I haz the power, 2017-03-11 01:03:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:14:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489194214647420,
"parent_rev": "062df28033e325db34be74c68da1f2bec888229d", "commit_rev":
"dd3c8c6e5537c766c0db2a05a1cb744f4b93bf19"}

[commit-bot: I haz the power, 2017-03-11 01:15:28]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file(
views, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=msw@chromium.org
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file(
views, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2740203004
Cr-Commit-Position: refs/heads/master@{#456244}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd3c8c6e5537c766c0db2a05a1cb...
==========

[commit-bot: I haz the power, 2017-03-11 01:15:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd3c8c6e5537c766c0db2a05a1cb...