Change base::Value::ListStorage to std::vector<base::Value>

extensions/browser/api/networking_private/networking_private_linux.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/networking_private/networking_private_linux.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 624 matching lines @@
   network_map_.swap(network_map);
   SendNetworkListChangedEvent(*network_list);
 }
 
 void NetworkingPrivateLinux::SendNetworkListChangedEvent(
     const base::ListValue& network_list) {
   GuidList guidsForEventCallback;
 
   for (const auto& network : network_list) {
     std::string guid;
-    base::DictionaryValue* dict;
-    if (network->GetAsDictionary(&dict)) {
+    const base::DictionaryValue* dict;

[Devlin, 2017/03/30 22:44:59]

nit: init to nullptr

[jdoerrie, 2017/04/07 13:56:17]

Done.

+    if (network.GetAsDictionary(&dict)) {
       if (dict->GetString(kAccessPointInfoGuid, &guid)) {
         guidsForEventCallback.push_back(guid);
       }
     }
   }
 
   OnNetworkListChangedEventOnUIThread(guidsForEventCallback);
 }
 
 bool NetworkingPrivateLinux::GetNetworkDevices(
@@ skipping 544 matching lines @@
                  base::Unretained(this), base::Passed(&guid_list)));
 }
 
 void NetworkingPrivateLinux::OnNetworksChangedEventTask(
     std::unique_ptr<GuidList> guid_list) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   OnNetworksChangedEventOnUIThread(*guid_list);
 }
 
 }  // namespace extensions