chrome/test/chromedriver/logging.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/logging.cc

diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc

index eacb53fa094fa6c968b30c340c4bced8075be3f7..101d47e9e1c14dea377125252970cbec8354b878 100644

--- a/chrome/test/chromedriver/logging.cc

+++ b/chrome/test/chromedriver/logging.cc

@@ -170,8 +170,8 @@ bool GetFirstErrorMessageFromList(const base::ListValue* list,

for (base::ListValue::const_iterator it = list->begin();

it != list->end();

++it) {

- base::DictionaryValue* log_entry = NULL;

- (*it)->GetAsDictionary(&log_entry);

+ const base::DictionaryValue* log_entry = NULL;

+ it->GetAsDictionary(&log_entry);

if (log_entry != NULL) {

std::string level;

if (log_entry->GetString("level", &level))