chrome/browser/ui/webui/site_settings_helper.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/site_settings_helper.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/site_settings_helper.cc

diff --git a/chrome/browser/ui/webui/site_settings_helper.cc b/chrome/browser/ui/webui/site_settings_helper.cc

index a79e82b942b470ae553b7d239e13ad5baff5c0df..e95b400018d4c7773e28810f13ff27371a43989d 100644

--- a/chrome/browser/ui/webui/site_settings_helper.cc

+++ b/chrome/browser/ui/webui/site_settings_helper.cc

@@ -306,7 +306,7 @@ void GetPolicyAllowedUrls(

std::vector<ContentSettingsPattern> patterns;

for (const auto& entry : *policy_urls) {

std::string url;

- bool valid_string = entry->GetAsString(&url);

+ bool valid_string = entry.GetAsString(&url);

if (!valid_string)

continue;