chrome/browser/ui/webui/options/language_options_handler_common.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/language_options_handler_common.cc

diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc

index c2f6468e75c35f5901826b84edb7b48a33001b19..9efcec86b083637e6b989d833d85e409644d5bc8 100644

--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc

+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc

@@ -266,7 +266,7 @@ void LanguageOptionsHandlerCommon::UpdateLanguageListCallback(

for (base::ListValue::const_iterator it = language_list->begin();

it != language_list->end(); ++it) {

std::string lang;

- (*it)->GetAsString(&lang);

+ it->GetAsString(&lang);

languages.push_back(lang);

}