chrome/browser/extensions/extension_override_apitest.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_override_apitest.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_override_apitest.cc

diff --git a/chrome/browser/extensions/extension_override_apitest.cc b/chrome/browser/extensions/extension_override_apitest.cc

index b1c8ae395904a1a6e870402141403d52478d3c31..ef7163fc2518fd43aae31068bdacc6c116e83dd0 100644

--- a/chrome/browser/extensions/extension_override_apitest.cc

+++ b/chrome/browser/extensions/extension_override_apitest.cc

@@ -46,7 +46,7 @@ class ExtensionOverrideTest : public ExtensionApiTest {

for (const auto& val : *values) {

const base::DictionaryValue* dict = nullptr;

std::string entry;

- if (!val->GetAsDictionary(&dict) || !dict->GetString("entry", &entry) ||

+ if (!val.GetAsDictionary(&dict) || !dict->GetString("entry", &entry) ||

seen_overrides.count(entry) != 0)

return false;

seen_overrides.insert(entry);