chrome/browser/extensions/api/content_settings/content_settings_store.cc - Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_store.cc

Issue 2740143002: Change base::Value::ListStorage to std::vector<base::Value> (Closed)

Patch Set: Fix Android Compilation Error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/extensions/api/declarative_content/content_action.cc » ('j') | chrome/browser/extensions/menu_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_store.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_store.cc b/chrome/browser/extensions/api/content_settings/content_settings_store.cc

index 8bed231ad3a3496bb6daa3278711266b4f7f1aa1..43fae06ff53cd0b8211bab077575d0280cce8c7c 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_store.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_store.cc

@@ -294,8 +294,8 @@ void ContentSettingsStore::SetExtensionContentSettingFromList(

const base::ListValue* list,

ExtensionPrefsScope scope) {

for (const auto& value : *list) {

- base::DictionaryValue* dict;

- if (!value->GetAsDictionary(&dict)) {

+ const base::DictionaryValue* dict;

Devlin 2017/03/30 22:44:59 nit: init to nullptr

jdoerrie 2017/04/07 13:56:17 Done.

+ if (!value.GetAsDictionary(&dict)) {

NOTREACHED();

continue;

}